Skip to content

Don't seed setuptools/wheel in tests virtual environments. #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Mar 22, 2025

per #2047 (comment)

What about dropping seeding setuptools and wheel on Python 3.8-3.11? I think it would be better if users specify every package they actually need (ideally via pyproject.toml), and they already have to do this to support 3.12+. If we did that, we could drop seeding anything into the venvs, which would be simpler and faster.

In fact build virtual environment already had dropped seeding those in v2.17 (#1725) but they were still seeded in the test virtual environment.

@henryiii henryiii merged commit 3b9c8d4 into pypa:main Mar 22, 2025
24 checks passed
@mayeut mayeut deleted the drop-legacy-seeds branch March 22, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants